Fly-Style commented on code in PR #19286: URL: https://github.com/apache/druid/pull/19286#discussion_r3092227901
########## indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/CostBasedAutoScaler.java: ########## Review Comment: > IMO, an auto-scaler implementation should not be deciding this (the supervisor should and it already does in the main loop) since this scale up/down logic is shared across scalers. I like SOLID, especially first letter, which is applicable here, I tend to agree with the general direction. But, we should clearly define the _responsibility limits_ of this entity, because e.g, when I started doing CBA, I clearly saw that the supervisor delegates a **decision making** to the autoscaler. We may reduce the responsibility just to raw task count calculation, and move decision making logic to other entity. That would be clean, IMO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
