jtuglu1 commented on code in PR #19286: URL: https://github.com/apache/druid/pull/19286#discussion_r3119847602
########## indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/CostBasedAutoScaler.java: ########## Review Comment: Looking more closely at this code: why are we bounding the output results of this result by the min/max task count? Shouldn't we bounding the results by the theoretical maximum (e.g. the partition count)? My issue with this is that we are removing observability into the case where the min/max task count is indeed misconfigured relative to what is the optimal task count. Would it not make more sense to compute the valid task counts relative to the stream? Then use the min/max bounds to flag these cases? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
