maytasm commented on code in PR #19286:
URL: https://github.com/apache/druid/pull/19286#discussion_r3075936803
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/CostBasedAutoScaler.java:
##########
@@ -561,16 +562,18 @@ private Either<String, Boolean>
validateMetricsForScaling(CostMetrics metrics)
}
/**
- * Determines if a scale action is currently allowed based on the elapsed
time
- * since the last scale action and the configured minimum scale-down delay.
+ * Determines if a scale action in the given direction is currently allowed
based on the elapsed time
+ * since the last scale action and the configured delay for that direction.
*/
- private boolean isScaleActionAllowed()
+ private boolean isScaleActionAllowed(boolean isScaleUp)
Review Comment:
nit: having isScaleUp as a boolean parameter for this method is a little
weird. Maybe refactoring to clear methods like isScaleUpActionAllowed and
isScaleDownActionAllowed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
