On Wed, 18 Feb 2026 16:34:42 GMT, Leo Korinth <[email protected]> wrote:
> I have removed the example usage of warning flags to remove the compiler > errors before integrating. If you remove this example, then the new `CFLAGS_CONVERSION_WARNINGS` variable is unused. Even if you plan on using this in a followup change, I think it would be more appropriate to introduce the variable then. OTOH, the title of the bug is "Allow conversion warnings in subsets of the code base", which is rather specific, while the patch is introducing a rather generic mechanism for adding flags to arbitrary subsets of code. I see two ways forward: 1. Remove `CFLAGS_CONVERSION_WARNINGS` from this patch, update the title to reflect what the patch is actually doing (introducing a generic way of applying flags to subsets of files) and save the actual enabling of warnings for a separate patch. 2. Keep the title, but also define an initial set of files for which this warning can be enabled. I'm actually more comfortable with 2 as it doesn't introduce dead/unused code. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29523#issuecomment-3922334717
