On Thu, 19 Feb 2026 16:43:58 GMT, Erik Joelsson <[email protected]> wrote:
>> Leo Korinth has updated the pull request incrementally with one additional >> commit since the last revision: >> >> use stricter flags on g1Numa.cpp that does not require any changes > > make/hotspot/lib/CompileJvm.gmk line 194: > >> 192: whitebox.cpp_CXXFLAGS := $(CFLAGS_SHIP_DEBUGINFO), \ >> 193: $(call ExtendFlags, $(TOPDIR)/src/hotspot/share/gc/g1, \ >> 194: g1Numa.cpp, _CXXFLAGS, $(CFLAGS_CONVERSION_WARNINGS)), \ > > Thanks for adding spaces and breaking the line. Stylewise this would be a > continuation indentation where we use 4 spaces as opposed to logical block > indentations where we use 2. Sorry for breaking all conventions all the time, new version pushed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29523#discussion_r2829563311
