On Thu, 12 Feb 2026 19:14:52 GMT, Erik Joelsson <[email protected]> wrote:
>> Leo Korinth has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Start with capital, strip spaces, use imperative mood, remove redundant >> comma > > make/hotspot/lib/CompileJvm.gmk line 192: > >> 190: abstract_vm_version.cpp_CXXFLAGS := $(CFLAGS_VM_VERSION), \ >> 191: arguments.cpp_CXXFLAGS := $(CFLAGS_VM_VERSION), \ >> 192: $(call >> ExtendFlags,$(TOPDIR)/src/hotspot/share/gc/g1,g1ConcurrentMark.cpp,_CXXFLAGS,$(CFLAGS_CONVERSION_WARNINGS)), >> \ > > Please also adhere to the convention of using space after comma in the call. > I think this line needs to be broken up too. As a general guide, the 80 char > wide `#` lines should be seen as soft limits on line length. Okay, I will probably remove the line before integrating as it currently breaks the build with new warnings. But if I get the source fixed before this change is integrated, I will add space after comma and try to line break at ~80. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29523#discussion_r2804149941
