On Wed, 11 Feb 2026 18:53:52 GMT, Leo Korinth <[email protected]> wrote:
>> make/autoconf/flags-cflags.m4 line 238:
>>
>>> 236: DISABLED_WARNINGS="$DISABLED_WARNINGS psabi"
>>> 237: fi
>>> 238: CFLAGS_CONVERSION_WARNINGS="-Wconversion -Wno-float-conversion"
>>
>> Maybe this should be called `CFLAGS_INTEGRAL_CONVERSION_WARNINGS`? As
>> there are other kinds of conversion warnings.
>
> From start it was including all floating point conversion warnings (before
> your changes), and I still get gcc warnigs involving floating point values:
> `error: conversion from 'jlong' {aka 'long int'} to 'double' may change value
> [-Werror=conversion]` with the command line ending in `-Wconversion
> -Wno-float-conversion` I think the reason is that only disables real-to-real
> and real-to-integral, but does not disables integral-to-real (that can also
> be lossy). Let us keep the name.
A pox on gcc. As noted elsewhere, clang seems to have a more fine-grained set
of warning knobs in this area. This probably means we'll need some mechanism
to deal with integer to float (potential) loss of precision warnings sooner
rather than later, but that should be dealt with separately.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29523#discussion_r2842877372
