On Mon, 9 Feb 2026 19:36:36 GMT, Kim Barrett <[email protected]> wrote:
>> Leo Korinth has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Using FindFiles in order to cache earlier file searches
>
> make/autoconf/flags-cflags.m4 line 238:
>
>> 236: DISABLED_WARNINGS="$DISABLED_WARNINGS psabi"
>> 237: fi
>> 238: CFLAGS_CONVERSION_WARNINGS="-Wconversion -Wno-float-conversion"
>
> Maybe this should be called `CFLAGS_INTEGRAL_CONVERSION_WARNINGS`? As
> there are other kinds of conversion warnings.
>From start it was including all floating point conversion warnings (before
>your changes), and I still get gcc warnigs involving floating point values:
>`error: conversion from 'jlong' {aka 'long int'} to 'double' may change value
>[-Werror=conversion]` with the command line ending in `-Wconversion
>-Wno-float-conversion` I think the reason is that only disables real-to-real
>and real-to-integral, but does not disables integral-to-real (that can also be
>lossy). Let us keep the name.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29523#discussion_r2794921009
