On Wed, 11 Feb 2026 19:19:11 GMT, Erik Joelsson <[email protected]> wrote:
>> Leo Korinth has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add comment regarding usage of function > > make/hotspot/lib/CompileJvm.gmk line 192: > >> 190: abstract_vm_version.cpp_CXXFLAGS := $(CFLAGS_VM_VERSION), \ >> 191: arguments.cpp_CXXFLAGS := $(CFLAGS_VM_VERSION), \ >> 192: $(call >> extendingFlags,$(TOPDIR)/src/hotspot/share/gc/g1,g1ConcurrentMark.cpp,_CXXFLAGS,$(CFLAGS_CONVERSION_WARNINGS)), >> \ > > Looking at this from a style perspective, we generally name macros with > initial letter capitalized. We also tend to use imperative mood, e.g. > ExtendFlags rather than extendingFlags. > > Looking at this call, can you make it work with whitespace after comma, i.e. > add calls to `strip` for every parameter in the top level macro. I know it > makes the macro definition harder to read, but it's required to be able to > line break this call, which it very much needs to be possible to do. I think I have addressed it all in the latest push. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29523#discussion_r2800172599
