Yuri,

Yep. I will be free again to put in some time this weekend to look at this.

I think that I must have broken the third-party jars that enable
federation some time when I tidied them all up a while back.
This wasn't found earlier because:
1) Nobody tried a completely clean build including re-fetching all the
third-party objects
2) The binary releases you produced were made using the old jars - so
contain one of the missing packages, hence the binary artifacts were
working fine when tested.

Things to note then:
1) Just because the binary artifacts work, they might not be the same
as the source artifacts
2) Always generate releases from a completely clean check out and run
everything again.

We were so close...
Ali

On 27 May 2015 at 08:33, Yuri Z <vega...@gmail.com> wrote:
> It looks like the wave release got stuck again. Anyways, let's discuss
> discuss how can we handle this...
>
> On Sun, May 17, 2015 at 5:21 PM Yuri Z <vega...@gmail.com> wrote:
>
>> I tested by checking out the RC 9 branch and fetching jars/building - it
>> worked fine. I didn't check federation.
>>
>>
>> On Thu, May 7, 2015 at 1:25 PM Ali Lown <a...@lown.me.uk> wrote:
>>
>>> If you fetch the jars do you have the same error trying to start the
>>> server?
>>>
>>> Ali
>>> On 7 May 2015 07:46, "Yuri Z" <vega...@gmail.com> wrote:
>>>
>>> > I didn't fetched the jars - just copied them from existing folder.
>>> >
>>> > On Thu, May 7, 2015 at 9:44 AM Yuri Z <vega...@gmail.com> wrote:
>>> >
>>> > > I see, what was the issue with federation?
>>> > >
>>> > > On Thu, May 7, 2015 at 3:00 AM Ali Lown <a...@lown.me.uk> wrote:
>>> > >
>>> > >> -1 due to the inability to start the server with federation enabled.
>>> > >> (I will change this to +1 if this is me failing to build correctly).
>>> > >>
>>> > >> Checked:
>>> > >> - SHA512 hashes and GPG signs
>>> > >> - Built using JDK7 and ran tests
>>> > >> - Checked README, CHANGES, KEYS, RELEASE-NOTES, build.properties
>>> > >> - Started server without federation using file backends. Tested wave
>>> > >> creation, simple editing, etc.
>>> > >> - Artifact naming seems good.
>>> > >> - Was unable to start server with federation (missing
>>> > >> org/xmpp/component/Log). Seems like a problem with the whack.jar file
>>> > >> that is fetched during build. This is making me wonder how it worked
>>> > >> in the RC8 binary package? @Yuri: Do you get the same error here, or
>>> > >> do you get something different when you build from the artifact in a
>>> > >> clean folder?
>>> > >>
>>> > >> Ali
>>> > >>
>>> > >> On 5 May 2015 at 18:23, Yuri Z <vega...@gmail.com> wrote:
>>> > >> > Great, thanks Ali. I checked that the source compiles and runs.
>>> > >> > On Tue 5 May 2015 at 17:39 Ali Lown <a...@lown.me.uk> wrote:
>>> > >> >
>>> > >> >> I think we may wish to extend the vote duration, as no-one seems
>>> to
>>> > >> >> have responded.
>>> > >> >>
>>> > >> >> I have just gotten around to this email in my inbox, so hope to
>>> get
>>> > to
>>> > >> >> this this evening...
>>> > >> >>
>>> > >> >> Ali
>>> > >> >>
>>> > >> >>
>>> > >> >>
>>> > >> >> On 29 April 2015 at 20:44, Yuri Z <vega...@gmail.com> wrote:
>>> > >> >> > RC9 is now available for review.
>>> > >> >> > Artifacts can be found here:
>>> > >> >> > https://dist.apache.org/repos/dist/dev/incubator/wave/0.4.0-rc9
>>> > >> >> > (Remember checksums are from 'gpg --print-md SHA512 $f >
>>> $f.sha')
>>> > >> >> > This time I included only source artifacts.
>>> > >> >> >
>>> > >> >> > The release version will be: 0.4.0-incubating
>>> > >> >> >
>>> > >> >> > This is taken from branch
>>> > >> >> >
>>> > >> >>
>>> > >>
>>> >
>>> https://git-wip-us.apache.org/repos/asf?p=incubator-wave.git;a=shortlog;h=refs/heads/0.4.0-RC9
>>> > >> >> >
>>> > >> >> > Reminder on what included previous release candidates:
>>> > >> >> > RC7 and RC8 included:
>>> > >> >> > - Release related fixes.
>>> > >> >> >
>>> > >> >> > RC6 included:
>>> > >> >> > - Bug Fixes
>>> > >> >> >
>>> > >> >> > RC5 included:
>>> > >> >> > - Added MongoDB based deltas store and migration tool for deltas
>>> > >> >> migration
>>> > >> >> > from file to mongo based store.
>>> > >> >> >
>>> > >> >> > - Added client/server profiling.
>>> > >> >> > - Added Atmosphere framework as replacement of Socket.IO.
>>> > >> >> > - Added alternative - Gmail style initials avatars.
>>> > >> >> > - Decreased number of permutations in dev compilation and added
>>> GWT
>>> > >> >> > superdev mode.
>>> > >> >> > - Upgraded the server to Jetty 9.1.1.
>>> > >> >> > - Added JDK 7 compatibility.
>>> > >> >> >
>>> > >> >> > RC4 included:
>>> > >> >> > - More licensing fixes
>>> > >> >> > - Federation works
>>> > >> >> > - New and updated translations
>>> > >> >> > - And more...
>>> > >> >> >
>>> > >> >> > A summary of useful information can be found in RELEASE-NOTES,
>>> and
>>> > a
>>> > >> list
>>> > >> >> > of changes in CHANGES at the above artifact distribution url, as
>>> > >> well as
>>> > >> >> > being included in the tarballs/zips.(zipballs?)
>>> > >> >> >
>>> > >> >> > Action Required:
>>> > >> >> > Test the release and make it works on your environment - at
>>> least
>>> > >> >> standard
>>> > >> >> > configurations. Please go over the source files and make sure
>>> they
>>> > >> don't
>>> > >> >> > contain anything that cannot be released under Apache Wave due
>>> to
>>> > >> legal
>>> > >> >> > issues.
>>> > >> >> >
>>> > >> >> > This vote will close around 0000 GMT 5-th May 2015.
>>> > >> >> >
>>> > >> >> > [ ] +1   Release it!
>>> > >> >> > [ ] +0   OK, but...
>>> > >> >> > [ ] -0    OK, but you really should fix....
>>> > >> >> > [ ] -1    Definitely not because...
>>> > >> >> >
>>> > >> >> > Thanks
>>> > >> >>
>>> > >>
>>> > >
>>> >
>>>
>>

Reply via email to