> On Fri, Aug 11, 2006 at 10:14:46AM -0500, Logan Shaw wrote:
> > What happens if the new set is broken?  There's no easy way
> > to revert to the last known good state.
>
> sa-update lint checks the new files in a separate temp area before
> installing them into the real directory.  Only if lint succeeds
> (which is also, of course, after verifying the sha1 and (by default)
> gpg signatures of the update file), will the currently
> installed channel
> files be removed and the new files installed.
>
> So there's no reverting involved for a "broken" update file.  Note:
> "broken" means an update file which has errors in it.  This algorithm
> doesn't address someone publishing valid config files that don't do
> what the publisher expected, ie: only empty or commented config files,
> no files, or <insert your favorite broken ruleset idea>.  IMO, channel
> publishing QA is really outside the scope of sa-update.

I agree, really. But I probably trust updates way more than most admins
do. (At least that's the feeling I get.) And if someone updates a
channel with a set of rules that lints but doesn't work right, they can
just re-release the old set as a new version and tell us to re-update.
But adding the option to archive will make at least some people more
comfortable with running sa-update. So I added the bz ticket. We'll see
where it goes.

Bret



Reply via email to