Re: [RFC PATCH 2/6] arm: dts: k3-j784s4-main: Add PBIST_14 node

[Kumar, Udit]

On 9/3/2024 5:13 PM, Neha Malcom Francis wrote:

Add DT node for PBIST_14 that is responsible for triggering the BIST
self-tests for the MAIN_R5_2_x cores.

Signed-off-by: Neha Malcom Francis <n-fran...@ti.com>
---
  dts/upstream/src/arm64/ti/k3-j784s4-main.dtsi | 10 ++++++++++
  1 file changed, 10 insertions(+)

diff --git a/dts/upstream/src/arm64/ti/k3-j784s4-main.dtsi 
b/dts/upstream/src/arm64/ti/k3-j784s4-main.dtsi
index 6a4554c6c9c..5d9b0b6b59d 100644
--- a/dts/upstream/src/arm64/ti/k3-j784s4-main.dtsi
+++ b/dts/upstream/src/arm64/ti/k3-j784s4-main.dtsi
@@ -2255,4 +2255,14 @@
                         */
                };
        };
+
+       bist_mcu14: bist@33c0000 {

Name shouldn't be mcu, if this is included in main .

Also consider to put this is kernel as well.

+               compatible = "ti,j784s4-bist";
+               reg = <0x00 0x033c0000 0x00 0x400>;
+               clocks = <&k3_clks 237 7>;
+               power-domains = <&k3_pds 237 TI_SCI_PD_EXCLUSIVE>;
+               bootph-pre-ram;
+               ti,bist-instance = <14>;
+               cores-under-test = <&main_r5fss2_core0>, <&main_r5fss2_core1>;
+       };
  };