Hi, Stefano > -----Original Message----- > From: Stefano Babic [mailto:sba...@denx.de] > Sent: 2010年6月18日 17:52 > To: Liu Hui-R64343 > Cc: w...@denx.de; u-boot@lists.denx.de > Subject: Re: [U-Boot] [U-BOOT][PATCH 4/5] serial_mxc: add support for MX53 > processor > > Jason Liu wrote: > > The patch adds support for the Freescale mx53 processor. > > > > Signed-off-by:Jason Liu <r64...@freescale.com> > > --- > > Hi Jason, > > > drivers/serial/serial_mxc.c | 7 +++++++ > > 1 files changed, 7 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/serial/serial_mxc.c b/drivers/serial/serial_mxc.c > > index 4b93e7b..e488595 100644 > > --- a/drivers/serial/serial_mxc.c > > +++ b/drivers/serial/serial_mxc.c > > @@ -55,6 +55,13 @@ > > #define UART_PHYS UART2_BASE_ADDR > > #elif defined(CONFIG_SYS_MX51_UART3) > > #define UART_PHYS UART3_BASE_ADDR > > +#elif defined(CONFIG_SYS_MX53_UART1) > > +#define UART_PHYS UART1_BASE_ADDR > > +#elif defined(CONFIG_SYS_MX53_UART2) > > +#define UART_PHYS UART2_BASE_ADDR > > +#elif defined(CONFIG_SYS_MX53_UART3) > > +#define UART_PHYS UART3_BASE_ADDR > > There are really no difference between MX51 and MX53, both set the same > values to UART_PHYS (at least as constant: even if the physical > address is different, must be unified at this place). I suggest something > like CONFIG_SYS_MX_UART1/2/3, that must be used for both > MX51 and MX53. Good idea! > > Best regards, > Stefano Babic > > -- > ===================================================================== > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de > =====================================================================
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
