> -----Original Message-----
> From: york sun
> Sent: Friday, August 05, 2016 10:54 PM
> To: Pratiyush Srivastava <pratiyush.srivast...@nxp.com>; u-
> b...@lists.denx.de
> Cc: Prabhakar Kushwaha <prabhakar.kushw...@nxp.com>
> Subject: Re: [PATCH][v2] board: ls1012afrdm: overwrite
> CONFIG_EXTRA_ENV_SETTINGS
> 
> On 08/05/2016 02:47 AM, Pratiyush Mohan Srivastava wrote:
> > From: Prabhakar Kushwaha <prabhakar.kushw...@nxp.com>
> >
> > LS1012AFRDM has 512MB of DDR.
> > So update Kernel load address as 0x96000000 instead of default
> > 0xa0000000.
> >
> > Signed-off-by: Prabhakar Kushwaha <prabhakar.kushw...@nxp.com>
> > Signed-off-by: Pratiyush Mohan Srivastava
> > <pratiyush.srivast...@nxp.com>
> > ---
> > Changes for v2: Incorporated York's comments
> >     - Removed ramdisk_addr, ramdisk_size
> >     - Updated UART baud-rate.
> >
> > include/configs/ls1012afrdm.h | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >
> > diff --git a/include/configs/ls1012afrdm.h
> > b/include/configs/ls1012afrdm.h index ad81142..f2c6ca8 100644
> > --- a/include/configs/ls1012afrdm.h
> > +++ b/include/configs/ls1012afrdm.h
> > @@ -39,4 +39,18 @@
> >  #define CONFIG_SYS_MEMTEST_START   0x80000000
> >  #define CONFIG_SYS_MEMTEST_END             0x9fffffff
> >
> > +#undef CONFIG_EXTRA_ENV_SETTINGS
> > +#define CONFIG_EXTRA_ENV_SETTINGS          \
> > +   "initrd_high=0xffffffff\0"              \
> 
> What is this?
[Pratiyush>] I used the LS1043 dts as the base for this dts. Since ls10143 had 
this parameter, I copied the same for LS1012. 
> 
> > +   "verify=no\0"                           \
> > +   "hwconfig=fsl_ddr:bank_intlv=auto\0"    \
> > +   "loadaddr=0x80100000\0"                 \
> > +   "kernel_addr=0x100000\0"                \
> > +   "fdt_high=0xffffffffffffffff\0"         \
> > +   "initrd_high=0xffffffffffffffff\0"      \
> > +   "kernel_start=0xa00000\0"               \
> > +   "kernel_load=0x96000000\0"              \
> > +   "kernel_size=0x2800000\0"               \
> > +   "console=ttyAMA0,115200n8\0"
> 
> Do you really use ttyAMA0? Isn't it ttyS0?
[Pratiyush>] I will remove the redundant console command.
> 
> York

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to