On Thu, 3 Sep 2026 18:29:56 GMT, Johan Sjölen <[email protected]> wrote:
>> It seems like "inlined_fields" has some meaning. Can you leave this name >> here without it being inconsistent. You could have has_flat_fields() too >> maybe in a further change? > > This should be `has_inlined_fields` or `has_flattened_fields`, it should not > be `has_value_fields`. I followed the chain of setters for this, and it > starts at `fieldLayoutBuilder.cpp:885`. It means "this IK has fields laid out > in a flat fashion" and not "some of the fields in here are values (as in > declared using `value class` or `value record`). Using my suggested names > makes this very explicit. Also see these comments about this: https://github.com/openjdk/jdk/pull/32673#discussion_r3925747823 https://github.com/openjdk/jdk/pull/32673#issuecomment-5530314561 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32673#discussion_r3927612437
