On Sat, 27 Dec 2025 11:25:25 GMT, Harald Eilertsen <[email protected]> wrote:
> The Mac OSX implementation of the Serviceability Agent and related code is > quite different from what's needed from the BSD implementation. Still we have > tried to keep the coexisting in one codebase in the out-of-tree BSD port, as > that's where the OSX code has been living. > > This sometimes cause problems when updates to the Mac OSX port breaks the BSD > implementation. > > As we are working on getting the BSD port into a state for future upstreaming > to the mainline repo, this patch clears the path by moving the Mac OSX > implementation of the Servicability Agent to a more fitting namespace. > > This should allow us to proceed with the BSD implementation undisturbed, but > also without risking breaking the OSX port. > > This work was sponsored by The FreeBSD Foundation - The JDK libraries have macosx directories, although within java.base/macosx we also see files with Bsd in the name. - Hotspot has the os/bsd directory. I assume this is for both bsd and macosx. I don't see a macosx directory under src/hotspot. - SA has a macosx directory, although it is only for the native libsaproc. - SA also has a bsd directory, and a number files with bsd in the name, some of which are in the bsd directory and some that are not. - I don't see any files with "darwin" in the path or name, but maybe it is a more appropriate name in some cases. My conclusion is that this is all rather poorly thought out and very inconsistent. I don't yet have a suggestion on how to proceed. I just wanted to better describe where things are at now. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29003#issuecomment-3716226494
