On Tue, 6 Jan 2026 02:39:08 GMT, David Holmes <[email protected]> wrote:
> My understanding was that "bsd" covered both macOS and potentially other BSD > derivatives, while "darwin" provided macOS specific code. Yes, traditionally it seems the OS X port was grown from the BSD port, but have since diverged significantly. In the BSD port maintained out of tree, a lot of the code under the `bsd` directories are essentially split by `#ifdef`'s where the OS X and BSD code are almost entirely separate, and the BSD code is synced with, and more closely resembles the Linux code. > You seem to be indicating that the existing "bsd" code only works for macOS > and so have renamed it all. The BSD code was broken in commit d3083ac05453c, and in trying to figure out how to fix it again it seemed easier to split the two implementations than to try to force them to coexist. This way the platforms would have less risk of breaking each others implementations. > If so that is fine (though a little surprising), but then having "macos" and > "darwin" as alternatives really makes no sense to me. ?? I can rename it to darwin instead, if you feel that is better. It seemed like "macosx" was more established when I looked around the source tree, but I'm happy to adapt. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29003#issuecomment-3714552414
