On Sat, 27 Dec 2025 11:25:25 GMT, Harald Eilertsen <[email protected]> wrote:
> The Mac OSX implementation of the Serviceability Agent and related code is > quite different from what's needed from the BSD implementation. Still we have > tried to keep the coexisting in one codebase in the out-of-tree BSD port, as > that's where the OSX code has been living. > > This sometimes cause problems when updates to the Mac OSX port breaks the BSD > implementation. > > As we are working on getting the BSD port into a state for future upstreaming > to the mainline repo, this patch clears the path by moving the Mac OSX > implementation of the Servicability Agent to a more fitting namespace. > > This should allow us to proceed with the BSD implementation undisturbed, but > also without risking breaking the OSX port. > > This work was sponsored by The FreeBSD Foundation I'm not sure about the approach here. My understanding was that "bsd" covered both macOS and potentially other BSD derivatives, while "darwin" provided macOS specific code. You seem to be indicating that the existing "bsd" code only works for macOS and so have renamed it all. If so that is fine (though a little surprising), but then having "macos" and "darwin" as alternatives really makes no sense to me. ?? Also while we have become stuck with using "macosx" in many places in the code, if we can we should use macos/macOS here. ------------- PR Review: https://git.openjdk.org/jdk/pull/29003#pullrequestreview-3629112451
