On Wed, 16 Oct 2024 18:25:46 GMT, Alex Menkov <amen...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: resolved comments from Alex and Chris
>
> test/hotspot/jtreg/serviceability/jvmti/events/NotifyFramePopStressTest/libNotifyFramePopStressTest.cpp
> line 160:
>
>> 158: err= jvmti->NotifyFramePop(thread, 0);
>> 159: if (err == JVMTI_ERROR_OPAQUE_FRAME || err == JVMTI_ERROR_DUPLICATE) {
>> 160: LOG("\nNotifyFramePop for method %d returned acceptable error:
>> %s\n", name, TranslateError(err));
>
> format for 1st arg (name) should be `%s`
> Suggestion:
>
> LOG("\nNotifyFramePop for method %s returned acceptable error: %s\n",
> name, TranslateError(err));
Thanks. I've also discovered and fixed it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21468#discussion_r1805014234
