On Thu, 17 Oct 2024 20:27:13 GMT, Alex Menkov <amen...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review test tweaks: add @bug tag; a reliability update
>
> test/hotspot/jtreg/serviceability/jvmti/events/NotifyFramePopStressTest/libNotifyFramePopStressTest.cpp
> line 171:
>
>> 169: } else {
>> 170: char* old_notify_method = (char*)last_notify_method;
>> 171: last_notify_method = name;
>
> I don't think this adds reliability.
> Control thread suspends main test thread before call this method. AFAIU
> suspend cannot complete before FramePop callback is completed.
Yes, this is all very synchronous. The control thread suspends the thread, we
call NotifyFramePop on the thread, the control thread resumes the thread and
then waits for confirmation of the FRAME_POP before repeating the process. I'm
not sure what motivated the change to add old_notify_method. Maybe there was
some other issue that was misunderstood.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21468#discussion_r1805444716
