On Tue, 15 Oct 2024 23:50:42 GMT, Alex Menkov <amen...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> minor comment tweak > > test/hotspot/jtreg/serviceability/jvmti/events/NotifyFramePopStressTest/libNotifyFramePopStressTest.cpp > line 49: > >> 47: static jvmtiEventCallbacks callbacks; >> 48: static volatile jint popCount = 0; >> 49: static char* lastNotifyMethod; > > it's accessed from different threads. should be volative at least (but better > would be be use atomic). The same for `popCount` and `failed` Thanks. Made volatile:`lastNotifyMethod` and `failed`. Renamed according to native naming convention: `popCount` => `pop_count`, `lastNotifyMethod` => `last_notify_method` ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21468#discussion_r1802235396
