On Tue, 15 Oct 2024 20:51:47 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> minor comment tweak > > test/hotspot/jtreg/serviceability/jvmti/events/NotifyFramePopStressTest/NotifyFramePopStressTest.java > line 57: > >> 55: Thread controlThread = new Thread(() -> control(testThread), >> "Control Thread"); >> 56: >> 57: setFramePopNotificationMode(testThread, true); > > I think we can get rid of this API and just have the native code default to > enabling FRAME_POP events. This was copied from a test that would turn it on > and off, but this test always needs it on. Thank you for the suggestion. I've removed the second parameter and defaulted it to `true`. The API is still useful as it points to the tested thread the FramePop events have to be enabled for. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21468#discussion_r1802055012
