On Wed, 4 Sep 2024 09:20:53 GMT, Kevin Walls <kev...@openjdk.org> wrote:
>> Deprecation annotations and warnings on starting the tool(s).
>> Handle man page in a separate issue.
>
> Kevin Walls has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Update src/jdk.hotspot.agent/doc/transported_core.html
>
> Co-authored-by: Chris Plummer <chris.plum...@oracle.com>
> - Update src/jdk.hotspot.agent/doc/index.html
>
> Co-authored-by: Chris Plummer <chris.plum...@oracle.com>
Can you paste in up to date examples of the output from `jhsdb debugd ..` and
`jhsdb jstack --connect .." so we can see the warnings. The output is in the
first comment has warnings in the --help output, and there isn't an example
using --connect that I think we need to review properly.
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/SALauncher.java line 73:
> 71: System.out.println(" --connect
> [<serverid>@]<host>[:registryport][/servername] To connect to a remote debug
> server (debugd).");
> 72: System.out.println();
> 73: System.out.println("WARNING: debugd (and therefore --connect)
> are deprecated and will be removed in a future release.");
This is -help output so I assume should be "The --connect option is deprecated
and will be removed in a future release".
-------------
Changes requested by alanb (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20830#pullrequestreview-2279530807
PR Review Comment: https://git.openjdk.org/jdk/pull/20830#discussion_r1743399459
