On Wed, 4 Sep 2024 19:33:24 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> --connect option text, not a WARNING
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/SALauncher.java line 75:
>
>> 73: System.out.println();
>> 74: if (canConnectToRemote) {
>> 75: System.out.println(" The --connect option is deprecated
>> and will be removed in a future release.");
>
> It is ok to add this, but now there is no longer any help message to explain
> what `--connect` does.
We have line 71 saying "--connect .....To connect to a remote debug server
(debugd)."
It's a long line and scanning it people might not read it all, but too late to
worry overly about that. 8-)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20830#discussion_r1745014127
