On Tue, 3 Sep 2024 14:48:05 GMT, Kevin Walls <kev...@openjdk.org> wrote:

> OK one other addition, as jhsdb debugd and the --connect option are two sides 
> of the same feature:
> 
> We generally expect attaches between the same JDK version (see the SA version 
> mismatch warning), so a later JDK with the ability to connect to a previous 
> JDK which still has debugd makes no sense.
> 
> We can warn at the tool running with --connect, e.g.
> 
> ```
> bash-4.2$ build/linux-x64/images/jdk/bin/jhsdb jstack --connect 
> serverid@debugserver:1234/servername
> WARNING: debugd (and therefore --connect) are deprecated and will be removed 
> in a future release.
> Attaching to remote server serverid@debugserver:1234/servername, please 
> wait...
> ```

I agree it doesn't make sense. For the warning message it might be clear to put 
the tool name into message, as in something like "WARNING: jhsdb jstack 
--connect is deprecated ...").

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20830#issuecomment-2326758831

Reply via email to