On Tue, 3 Sep 2024 10:31:40 GMT, Kevin Walls <kev...@openjdk.org> wrote:
>>> Maybe we can call these tags pointless. But they do give a useful check >>> that our own code (which should be limited to the tool being deprecated >>> here) has to be aware of and suppress the deprecation. >> >> If you find them useful then okay, main thing is that this is all internal >> to the jdk.hotspot.agent module. In some future release then this code will >> be removed and maybe the deprecated annotation will help identify the dead >> code. > > Yes all internal and the tags do not increase our commitment, just may help > with finding edge cases. I think they are useful and cheap, thanks. It's okay to include them in the PR but don't list them in the CSR as they aren't part of any interface, they are just internal to this module. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20830#discussion_r1743148163
