On Fri, 16 Oct 2026 21:43:50 GMT, Weijun Wang <[email protected]> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> address review comments from Weijun and additional refactoring and clean >> up, etc. > > src/java.base/share/classes/com/sun/crypto/provider/Argon2Impl.java line 228: > >> 226: i2bLittle4(k, h0Plus8Bytes, 68); >> 227: blocks[k][0] = new Block(vlHash(ARGON2_BLOCK_SIZE, >> 228: h0Plus8Bytes)); > > Do you need to clean up the output of `vlHash`? I see you erase the content > of all blocks at the end. These are equivalent. Hmm, right, let me do that as well. Thanks for catching this. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r4320472535
