On Fri, 9 Oct 2026 01:19:14 GMT, Valerie Peng <[email protected]> wrote:

>> Initial commit containing the public API changes and related regression 
>> tests.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Valerie Peng has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   address review comments from Weijun and additional refactoring and clean
>   up, etc.

test/jdk/javax/crypto/spec/Argon2ParameterSpec/InvalidArgs.java line 47:

> 45: 
> 46:         final Builder b = Argon2ParameterSpec.newBuilder();
> 47:         Utils.runAndCheckException(()->b.build(b8, b8), iaeCls);

I heard new tests are recommended to use `Asserts.assertThrows`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r4299411419

Reply via email to