On Fri, 9 Oct 2026 01:19:14 GMT, Valerie Peng <[email protected]> wrote:
>> Initial commit containing the public API changes and related regression >> tests. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Valerie Peng has updated the pull request incrementally with one additional > commit since the last revision: > > address review comments from Weijun and additional refactoring and clean > up, etc. src/java.base/share/classes/com/sun/crypto/provider/Argon2Impl.java line 228: > 226: i2bLittle4(k, h0Plus8Bytes, 68); > 227: blocks[k][0] = new Block(vlHash(ARGON2_BLOCK_SIZE, > 228: h0Plus8Bytes)); Do you need to clean up the output of `vlHash`? I see you erase the content of all blocks at the end. These are equivalent. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r4299640045
