On Fri, 16 Oct 2026 21:15:19 GMT, Weijun Wang <[email protected]> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> address review comments from Weijun and additional refactoring and clean >> up, etc. > > test/jdk/javax/crypto/spec/Argon2ParameterSpec/InvalidArgs.java line 47: > >> 45: >> 46: final Builder b = Argon2ParameterSpec.newBuilder(); >> 47: Utils.runAndCheckException(()->b.build(b8, b8), iaeCls); > > I heard new tests are recommended to use `Asserts.assertThrows`. Ok, I can change to use that. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r4320393905
