On Wed, 19 Aug 2026 09:48:42 GMT, Bernd <[email protected]> wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> import cleanup. > > src/java.base/share/classes/com/sun/crypto/provider/Argon2DerivedKey.java > line 133: > >> 131: } >> 132: >> 133: if (isDestroyed()) { > > Should this throw for the idendity check as well.. and on the other hand > don’t we lose the ability to remove it from HashSets once it’s destroyed, for > not really a good reason?
I will change this part of code. Could you please take another look later and let me know if there is still issue. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r4204200982
