On Wed, 19 Aug 2026 13:40:16 GMT, Sean Mullan <[email protected]> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> import cleanup. > > src/java.base/share/classes/javax/crypto/spec/Argon2ParameterSpec.java line > 43: > >> 41: * iterations, degree of parallelism, output tag length, version, and >> optional >> 42: * secret and associated data. >> 43: * > > I think you need a sentence here explaining how to create > `Argon2ParameterSpec` objects with a builder, you could then lead right into > the next sentence, ex: > > "`Argon2ParameterSpec`s are constructed with an `Argon2ParameterSpec.Builder` > and then used to initialize a `KDF` object ..." Ok. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r4204295247
