On Wed, 19 Aug 2026 13:54:02 GMT, Sean Mullan <[email protected]> wrote:

>> Valerie Peng has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   import cleanup.
>
> src/java.base/share/classes/javax/crypto/spec/Argon2ParameterSpec.java line 
> 47:
> 
>> 45:  * for one of the {@code Argon2} algorithm: {@code Argon2i}, {@code 
>> Argon2d},
>> 46:  * or {@code Argon2id}.
>> 47:  *
> 
> I also think it would be useful to include a code sample showing a more 
> common configuration - the one from the JEP would be good. Argon2 has a lot 
> of parameters, so a code sample would be a good idea.

Yes, will do.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r4202308624

Reply via email to