On Wed, 19 Aug 2026 16:58:50 GMT, Sean Mullan <[email protected]> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> import cleanup.
>
> src/java.base/share/classes/javax/crypto/spec/Argon2ParameterSpec.java line
> 286:
>
>> 284: /**
>> 285: * Builds an {@code Argon2ParameterSpec} object from the
>> specified
>> 286: * {@code salt}, {@code password}, and builder parameters.
>
> I think you need to say which parameters are cloned/copied, ex: "Copies of
> the salt, password, secret (if specified) and associated data (if specified)
> are made when creating the `Argon2ParameterSpec` object."
The cloning is done inside the private Argon2ParameterSpec constructor as a
defensive measure. IIRC, we only mention cloning when handling mutable data out
to the caller but we don't mention the defensive cloning when taking data in.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r4202957655
