On Fri, 21 Aug 2026 15:43:27 GMT, Weijun Wang <[email protected]> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> import cleanup.
>
> src/java.base/share/classes/javax/crypto/spec/Argon2ParameterSpec.java line
> 45:
>
>> 43: *
>> 44: * <p>This class can be used to initialize a {@link javax.crypto.KDF}
>> object
>> 45: * for one of the {@code Argon2} algorithm: {@code Argon2i}, {@code
>> Argon2d},
>
> `KDFParameters` is used to "initialize a KDF". This class will be used as
> input to derivation.
Yes, good catch. Will update the wording.
> src/java.base/share/classes/sun/security/provider/ByteArrayAccess.java line
> 211:
>
>> 209: * special optimized long to byte[] conversion, little endian byte
>> order
>> 210: */
>> 211: public static void l2bLittle8(long value, byte[] in, int inOfs) {
>
> This is `out` and `outOfs`.
Yes, will fix.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r4203158916
PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r4203154505
