On Fri, 21 Aug 2026 21:09:31 GMT, Weijun Wang <[email protected]> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> import cleanup.
>
> src/java.base/share/classes/javax/crypto/spec/Argon2ParameterSpec.java line
> 319:
>
>> 317: * or has fewer than 8 bytes; if {@code passwdChar} or
>> 318: * {@code cs} is {@code null}; or if any required
>> builder
>> 319: * parameter has not been set.
>
> There is a period at the end of this `@throws` but none in the one of the
> method above. Please be consistent.
Will remove all trailing period for the `@throws` description.
> src/java.base/share/classes/javax/crypto/spec/Argon2ParameterSpec.java line
> 474:
>
>> 472:
>> 473: /**
>> 474: * Clears the password and the secret value held by this object.
>
> I wonder if user would ask how to clear the secret in a `Builder`. Maybe let
> it implements`Destroyable` is too big. Maybe we can add a sentence in
> `Builder::secret(byte[] k)` that calling it will clear the previous secret.
> At least curious users will find a way.
Hmm, ok, I will add some wording to builder's secret(byte[]) about this.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r4203286767
PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r4203274513
