On Fri, 21 Aug 2026 21:03:30 GMT, Weijun Wang <[email protected]> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> import cleanup.
>
> src/java.base/share/classes/javax/crypto/spec/Argon2ParameterSpec.java line
> 178:
>
>> 176: * if {@code m} is less than 8; or if {@code
>> parallelism(p)}
>> 177: * has already been called and {@code m} is less than
>> 178: * {@code 8 * p}
>
> I don't know if this will be a real problem: suppose user first set `m = 8; p
> = 1` and then decide to switch to `m = 16; p = 2`. They will need to remember
> to first adjust `m` and then `p` otherwise changing `p` will throw an
> exception. Maybe no serious user would set `m` as low as 8, but what about `m
> = 32, p = 4` or more? This is still a problem.
Hmm, ok, good point, I changed to only do the cross-parameter checking inside
`build(...)` and this should address this call-ordering issue.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r4203207452
