On Thu, 8 May 2025 21:32:13 GMT, Weijun Wang <wei...@openjdk.org> wrote:

>> There is an inconsistency with PEMRecord here.  These methods should not 
>> allow leadingData if it is not available elsewhere.  I will redo that.  
>> leadingData can be reserved for the decode methods that take a class.
>> 
>> I tried not to mention the pointer position.  My opinion is these methods 
>> should not have to describe the InputStream functionality.  I already state 
>> it returns a value after it finds PEM and I think one can figure this out.
>
> See 
> https://github.com/openjdk/jdk/blob/002679ac9fe4de8150b7dd4c9aeb44eeef1257d6/src/java.base/share/classes/java/security/cert/CertificateFactory.java#L338-L347

IO focuses more on the read position now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r2089792916

Reply via email to