On Wed, 7 May 2025 16:42:20 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Anthony Scarpino has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains 66 commits: >> >> - major code review comments update >> - Merge branch 'master' into pem >> - Merge branch 'master' into pem >> - javadoc updates >> - code review comments >> - merge with master >> - better comment and remove commented out code >> - Merge branch 'master' into pem >> - Merge branch 'pem-merge' into pem >> - merge >> - ... and 56 more: https://git.openjdk.org/jdk/compare/e2ae50d8...0c540327 > > src/java.base/share/classes/java/security/PEMDecoder.java line 118: > >> 116: /** >> 117: * Returns an instance of {@code PEMDecoder}. This instance may be >> repeatedly used >> 118: * to decode different PEM text. > > Not only repeatable, but also thread safe I assume? Maybe we need to talk > about this in the class spec. Immutable does not automatic implies > thread-safe, if the immutability is only observed on the API level. Usually there is a sentence at the end of the class description, ex- "This class is immutable and thread-safe." Once you state that, you don't need to say anything more in the methods like the sentence above about repeatability. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r2078310045
