On Thu, 8 May 2025 04:09:02 GMT, Anthony Scarpino <ascarp...@openjdk.org> wrote:
>> src/java.base/share/classes/java/security/PEMDecoder.java line 71:
>>
>>> 69: * with {@linkplain #withFactory} and/or {@linkplain #withDecryption}.
>>> 70: * Configuring an instance for decryption does not prevent decoding with
>>> 71: * unencrypted PEM. Any encrypted PEM that does not use the configured
>>> password
>>
>> I found the last 3 sentences a bit jumping too quickly into details. I
>> suggest having 2 sentences after the first one, where each sentence explains
>> what the `withDecryption` and `withFactory` methods do, respectively.
>
> I split them and reworded it, HTH.
What I was suggesting was to have an additional sentence first describing what
each of these methods is for. I'll suggest something later.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r2081930885
