On Tue, 6 May 2025 20:49:10 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Anthony Scarpino has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains 66 commits: >> >> - major code review comments update >> - Merge branch 'master' into pem >> - Merge branch 'master' into pem >> - javadoc updates >> - code review comments >> - merge with master >> - better comment and remove commented out code >> - Merge branch 'master' into pem >> - Merge branch 'pem-merge' into pem >> - merge >> - ... and 56 more: https://git.openjdk.org/jdk/compare/e2ae50d8...0c540327 > > src/java.base/share/classes/java/security/PEMEncoder.java line 48: > >> 46: /** >> 47: * PEMEncoder is an immutable class for Privacy-Enhanced Mail (PEM) >> 48: * data. PEM is a textual encoding used to store and transfer security > > "An immutable class .. for ... data" sounds like it is the data itself. What > about "for encoding data into...". > > The first word `PEMEncoder` should be in `<code>`. ok ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r2087139518
