On Sun, 8 Sep 2024 16:32:25 GMT, Alan Bateman <[email protected]> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> updated comments around locking mechanism
>
> src/java.base/share/classes/javax/crypto/KDFSpi.java line 51:
>
>> 49: * Implementations which do not support {@code KDFParameters} may require
>> 50: * {@code null} to be passed, otherwise an {@code
>> InvalidAlgorithmParameterException}
>> 51: * may be thrown. On the other hand, implementations which require
>
> I think you may need to clarify this paragraph for both provider
> implementations and anything that uses the concrete implementation. For a
> non-null kdfParameters that is not supported, the current wording seems to
> allow a provider to ignore parameters that it doesn't support, is that the
> intention?
@AlanBateman: I believe
https://github.com/openjdk/jdk/pull/20301/commits/efde3bb80a460d6039372874e31fca9008c054af
improves things, but let me know if you feel it needs further word-smithing.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1757664211
