On Tue, 10 Sep 2024 15:25:53 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> updated comments around locking mechanism
>
> src/java.base/share/classes/javax/crypto/KDF.java line 349:
>
>> 347: Object obj = s.newInstance(kdfParameters);
>> 348: if (!(obj instanceof KDFSpi spiObj)) {
>> 349: lastException = new NoSuchAlgorithmException(
>
> Unless I'm mistaken, you don't need to wrap the IAPE in a NSAE, only to
> unwrap it again in `handleException()`. I think you can throw it directly as
> an IAPE on line 379.
@seanjmullan: I considered this, but then I would have to make the type of
`lastException` more generic (ie - `Exception`) which would require additional
inspection later.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1755700020
