On Fri, 6 Sep 2024 18:45:42 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924). > > Kevin Driver has updated the pull request incrementally with one additional > commit since the last revision: > > updated comments around locking mechanism src/java.base/share/classes/java/security/KDFParameters.java line 30: > 28: > 29: /** > 30: * A specification of {@code KDF} parameters. A passing comment on KDFPraameters. It doesn't spell out what "KDF" stands for, and doesn't seem to link to KDF in the class description. src/java.base/share/classes/javax/crypto/KDFSpi.java line 37: > 35: /** > 36: * This class defines the <i>Service Provider Interface</i> (<b>SPI</b>) > for the > 37: * {@code KDF} class. KDFSpi is the same, I guess I expected to see "Key Derivation Function" and a link to KDF in the first paragraph. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1749284637 PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1749285067
