On Fri, 6 Sep 2024 14:06:51 GMT, Viktor Klang <vkl...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 31 additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'origin/master' into kdf-jep-wip >> # Please enter a commit message to explain why this merge is necessary, >> # especially if it merges an updated upstream into a topic branch. >> # >> # Lines starting with '#' will be ignored, and an empty message aborts >> # the commit. >> - several more review comments >> - change impl class to use byte arrays rather than SecretKey objects where >> possible >> - updated delayed provider selection javadoc >> - review comments >> - use a delegate record to hold the spi and provider >> - assorted review comment changes >> - another round of review comments >> - consistency with wording for addIKM and addSalt >> - another round of code review comments >> - ... and 21 more: https://git.openjdk.org/jdk/compare/2669f13e...a35e98c9 > > src/java.base/share/classes/javax/crypto/KDF.java line 126: > >> 124: private Iterator<Service> serviceIterator; >> 125: >> 126: private final Object lock; > > It might be better to do the following, as it should be the same thing no > matter which constructor is used. > > Suggestion: > > private final Object lock = new Object(); Addressed in https://github.com/openjdk/jdk/pull/20301/commits/5573558cc0c78a2acc9713d27eab8a082ce5ff78. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1747569833
