On Tue, 10 Sep 2024 16:05:07 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> updated comments around locking mechanism > > src/java.base/share/classes/java/security/KDFParameters.java line 25: > >> 23: * questions. >> 24: */ >> 25: package java.security; > > This should be in the `javax.crypto` package since it is specific to KDF > which is also in the `javax.crypto` package. @seanjmullan: Refactored to the above package in https://github.com/openjdk/jdk/pull/20301/commits/dc0bd1552ea14adaec4cc8e67d4213826c1b175c. > src/java.base/share/classes/javax/crypto/KDF.java line 54: > >> 52: * The class has two derive methods, {@code deriveKey} and {@code >> deriveData}. >> 53: * The {@code deriveKey} method accepts an algorithm {@code String} and >> 54: * will return a {@code SecretKey} object with the specified algorithm. >> The > > Keep wording consistent with next sentence ("returns a byte array"). > > s/will return/returns/ @seanjmullan: Addressed in https://github.com/openjdk/jdk/pull/20301/commits/dc0bd1552ea14adaec4cc8e67d4213826c1b175c. > src/java.base/share/classes/javax/crypto/KDF.java line 94: > >> 92: * optional {@code KDFParameters} is chosen. This provider may not >> support >> 93: * the key material that is subsequently passed to the deriveKey or >> 94: * deriveData methods. Therefore, it is recommended not to call the >> {@code > > Put @code around deriveKey and deriveData. @seanjmullan: Addressed in https://github.com/openjdk/jdk/pull/20301/commits/dc0bd1552ea14adaec4cc8e67d4213826c1b175c. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1752662120 PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1752660306 PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1752660661
