On Fri, 6 Sep 2024 12:51:10 GMT, Viktor Klang <vkl...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 31 additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'origin/master' into kdf-jep-wip >> # Please enter a commit message to explain why this merge is necessary, >> # especially if it merges an updated upstream into a topic branch. >> # >> # Lines starting with '#' will be ignored, and an empty message aborts >> # the commit. >> - several more review comments >> - change impl class to use byte arrays rather than SecretKey objects where >> possible >> - updated delayed provider selection javadoc >> - review comments >> - use a delegate record to hold the spi and provider >> - assorted review comment changes >> - another round of review comments >> - consistency with wording for addIKM and addSalt >> - another round of code review comments >> - ... and 21 more: https://git.openjdk.org/jdk/compare/511a2b2a...a35e98c9 > > src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java > line 70: > >> 68: */ >> 69: HkdfKeyDerivation(String hmacAlgName, int hmacLen, >> 70: KDFParameters kdfParameters) > > Why does this take KDFParameters if hmacAlgName doesn't support parameters? This block is contained in the `KDFSpi` class header: * In addition, all implementations must provide a public constructor which * accepts a {@code KDFParameters} object. The constructor must call {@code * super(params)} passing the parameters supplied. The constructor must also * throw an {@code InvalidAlgorithmParameterException} if the supplied * parameters are inappropriate. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1747520868
