On Fri, 30 Aug 2024 23:26:12 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924). > > Kevin Driver has updated the pull request incrementally with one additional > commit since the last revision: > > change impl class to use byte arrays rather than SecretKey objects where > possible src/java.base/share/classes/javax/crypto/KDF.java line 350: > 348: lastException = new NoSuchAlgorithmException( > 349: new InvalidAlgorithmParameterException( > 350: "newInstance failed to provide a KDFSpi for > the " The caller does not need to know about internal methods named `newInstance` so these should not be exposed in exception messages. How about something simpler like "No provider can be found that supports the specified parameters". Same comment on line 365. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1746029364
