On Thu, 5 Sep 2024 15:54:24 GMT, Viktor Klang <vkl...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> change impl class to use byte arrays rather than SecretKey objects where >> possible > > src/java.base/share/classes/javax/crypto/KDF.java line 367: > >> 365: "newInstance failed for the provided " >> 366: + "kdfParameters")); >> 367: continue; > > Given the structure of the loop this statement is a no-op. > > Suggestion: Yes, I noticed this but left it since I found it useful in reading the code, perhaps I'll replace it with a comment instead. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1745935270
