On Thu, 5 Sep 2024 17:42:17 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> src/java.base/share/classes/javax/crypto/KDF.java line 367: >> >>> 365: "newInstance failed for the provided " >>> 366: + "kdfParameters")); >>> 367: continue; >> >> Given the structure of the loop this statement is a no-op. >> >> Suggestion: > > Yes, I noticed this but left it since I found it useful in reading the code, > perhaps I'll replace it with a comment instead. Replaced with a comment in https://github.com/openjdk/jdk/pull/20301/commits/59b1743fd225ff34e6bcce055fd47a887ed22a08. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1746240128
